Silence pmd and spotbugs warnings

[MarkEWaite]

📝 Description

Silence pmd and spotbugs warnings.

• Remove unnecessary parentheses
• Remove unnecessary final on resource usage
• Combine nested if statements into single statement
• Remove unused import
• Use simpler reference to field
• Use maven pmd plugin 3.21.2
• Move spotbugs filter to default location
• Use parent pom 4.76
• Suppress existing spotbugs warnings

🎯 Relevant issues

N/A

💎 Type of change

• Maintenance

🚦 How Has This Been Tested?

Automated tests pass. No other testing performed.

🏁 Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• New and existing unit tests pass locally with my changes
• I have commented my code, particularly in hard-to-understand areas

[MarkEWaite]

Replaces:

• Resolve pmd warnings and upgrade pmd #90

[MarkEWaite]

I assumed that the issue in the GitHub action was related to the non-zero count of spotbugs warnings, so I included suppressions of the spotbugs warnings in this pull request. My assumption was wrong, though I believe this is ready for review, whether or not the GitHub actions pass. It reduces the spotbugs warnings to zero and configures spotbugs to fail if new warnings are introduced.

[hypery2k]

okay, worked after merging, but on MR there seems an permission issue. Have to check that

thanks for your contribution