Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move configuration from ToolInstallation to GlobalConfiguration #43

Merged
merged 25 commits into from
Jan 30, 2018

Commits on Dec 11, 2017

  1. properly get displayname of node

    use the executor of the build to get the node.
    builtOn is set too late for us to get the node and we end up using
    master
    mwinter69 committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    371e27b View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2017

  1. displayname of node in pipeline

    properly get the node when BuildData is initilaized from a pipeline
    pump mockito to latest version
    add integration test, that use Jenkins test harness
    mwinter69 committed Dec 16, 2017
    Configuration menu
    Copy the full SHA
    67bc346 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2017

  1. refactoring

    the plugin used a ToolInstallation for configuration. But logstash is
    not a tool that can be installed. Instead this should be a
    GlobalConfiguration.
    The indexers have different configuration requirements. Host and port
    are common, but things like username are not required everywhere. Also
    the previous implementation was totally unflexible. In order to add a
    new indexer one has to modify the sources. By configuring the indexers
    via an extension point we make it easily possible to have individual
    configuration jelly for each type. Adding a new indexer is just adding
    new classes. So it can be even moved to a separate plugin.
    
    Many of the fields in the plugin were public or package private. They
    have been made private or protected with corresponding getters and
    setters and direct calls to the fields replaced.
    
    Get the charset of a run and use it whenever we need to convert the
    String to a byte array
    
    Use DateFormatter from apache common lang to avoid potential threading
    problems.
    mwinter69 committed Dec 27, 2017
    Configuration menu
    Copy the full SHA
    c252ac8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    faf30cd View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from jenkinsci/master

    properly get displayname of node (jenkinsci#38)
    mwinter69 authored Dec 27, 2017
    Configuration menu
    Copy the full SHA
    6b4c6d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2017

  1. jenkins and java

    use Jenkins 2.7.4 instead of 2.60.3
    fix problem with cast that is requried with java 7
    mwinter69 committed Dec 28, 2017
    Configuration menu
    Copy the full SHA
    333ca41 View commit details
    Browse the repository at this point in the history
  2. fix findbugs issues in buildData

    Use FastDateFormat from apache which is thread safe
    
    Avoid possible NPE in Node detection
    Avoid possible NPE in result (previous logic already avoided it but findbugs
    still claimed it to be a problem)
    
    Node detection is same for pipeline and freestyle so move it to initData
    method
    mwinter69 committed Dec 28, 2017
    Configuration menu
    Copy the full SHA
    ca4eca8 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2017

  1. Merge branch 'master' of https://github.com/jenkinsci/logstash-plugin

    …into jenkinsci-master
    mwinter69 committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    45a03ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59d1a77 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2017

  1. Merge pull request #3 from jenkinsci/master

    reduce visibility of fields (jenkinsci#46)
    mwinter69 authored Dec 31, 2017
    Configuration menu
    Copy the full SHA
    96deff1 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2018

  1. Configuration menu
    Copy the full SHA
    379c5e4 View commit details
    Browse the repository at this point in the history
  2. javadoc and readme

    update javadoc to get more information for developers that want to
    extend the plugin.
    Update the readme
    Use the not deprecated junit runner of mockito
    mwinter69 committed Jan 1, 2018
    Configuration menu
    Copy the full SHA
    1321104 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4974276 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2018

  1. Configuration menu
    Copy the full SHA
    227611b View commit details
    Browse the repository at this point in the history
  2. incorporate feedback

    rename junit test methods
    synchronize getting the dao instance to avoid problems.
    deprecate enums
    mwinter69 committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    d602a6e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7340194 View commit details
    Browse the repository at this point in the history
  4. adjust link to plugin page

    mwinter69 committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    6116410 View commit details
    Browse the repository at this point in the history
  5. simplify equals

    mwinter69 committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    ac70407 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. host based indexers vs uri

    introduce an abstract host based indexer that serves as base for most
    indexers. Elastic search uses a uri approach where we need scheme, host,
    port and url path, so we allow to configure a uri instead.
    mwinter69 committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    87c93cb View commit details
    Browse the repository at this point in the history
  2. add some todos

    mwinter69 committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    f021a43 View commit details
    Browse the repository at this point in the history
  3. use URL instead of URI

    stapler is not able to autconvert String to URI
    add more TODOs
    mwinter69 committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    fdc79cc View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. use URI as persistence for elastic search url

    URI can be easier compared
    some minor changes in tests
    mwinter69 committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    dac27f1 View commit details
    Browse the repository at this point in the history
  2. fix test

    mwinter69 committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    f2c4a24 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2018

  1. use ExpectedException rule

    mwinter69 committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    add8146 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. Configuration menu
    Copy the full SHA
    d28cab4 View commit details
    Browse the repository at this point in the history