Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logz.io support #74
base: master
Are you sure you want to change the base?
Add Logz.io support #74
Changes from 42 commits
d986d80
8a00ac8
de18b60
4ef9a2f
8c185d6
6c7d6a6
9b7621d
5075433
fa317c1
bf87eec
6d53f29
4d9134d
54cd262
7a9164d
959f715
03cb931
035fb68
53ffac5
84aed45
193f057
4dbe73e
89a41e9
25c63b4
bdab1a3
488037f
144e922
30ccd6b
bf200ca
f2dc75e
ad75e1e
6c27e9b
84d2051
bd0ba73
22d88bc
63647d6
6a70412
f57f163
bd062d0
594c37d
07fcdb4
e2fb882
74fa7f6
93732e3
203eca1
d31850b
b3ffe89
77577d9
e7b056e
1508b3f
3e37735
605a76c
f5e9581
1aec70e
84c3602
93a5cd2
b1dc099
261f22c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not synchronized this will become a problem as soon as you have multiple parallel builds. Use
Collections.synchronizedList(new ArrayList<>())
Makes it thread safe probably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I forgot it has to be synchronized if we reuse it on the -Dao level