Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-40766] add pipeline support #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

estarter
Copy link

@estarter estarter commented Jan 5, 2017

Pipeline support is added to release plugin. Release can be triggered from pipeline as following:
m2release job: 'jobname'

I was using pipeline-build-step-plugin as a reference as well as release-plugin.

I've done few modifications in order to be able to start developing on the plugin (currently compilation is failing on master brunch):

  1. fixed javadoc errors
  2. junit tests updated to use @Rules instead of inheriting HudsonTestCase
  3. missing header <?jelly escape-by-default='true'?> was added to *.jelly files

@jtnord
Copy link
Member

jtnord commented Aug 29, 2017

@estarter sorry - just noticed the lingering PRs here. Any chance you could split the plugin/test updates from the pipeline support?

Currently there are findbugs issues - they do not seem to be relevant except that they are being recorded as part of the plugin bump which is then causing the PR build to fail.

@jtnord jtnord mentioned this pull request Aug 29, 2017
@jtnord
Copy link
Member

jtnord commented Aug 29, 2017

some overlap and possible conflicts with #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants