Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid redirect computation (fix #285) #286

Merged

Conversation

michael-doubez
Copy link
Contributor

@michael-doubez michael-doubez commented Apr 1, 2024

Change redirect computation logic to accomodate for jenkins configured with path prefix.
This fixes the regression introduced in #261 while keeping the check on open redirect vulnerability.

Testing done

Submitter checklist

Preview Give feedback

@michael-doubez michael-doubez self-assigned this Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (22331f0) to head (37c11e7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
+ Coverage     71.90%   72.61%   +0.70%     
+ Complexity      194      187       -7     
============================================
  Files             9        9              
  Lines           744      745       +1     
  Branches        124      116       -8     
============================================
+ Hits            535      541       +6     
+ Misses          150      146       -4     
+ Partials         59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez merged commit 3661066 into jenkinsci:master Apr 2, 2024
18 checks passed
@michael-doubez michael-doubez deleted the fix-invalid-redirect branch April 2, 2024 19:00
@michael-doubez
Copy link
Contributor Author

Change validated by hand as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant