Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-activate spotless #311

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

krezovic
Copy link
Contributor

@krezovic krezovic commented May 1, 2024

Follow-up for 57eca2d

It appears that the maven property override disabled the options initially used to format the project, so right now there's spaghetti formatting enabled.

@krezovic krezovic requested a review from a team as a code owner May 1, 2024 20:02
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.32%. Comparing base (e327bf2) to head (1354b94).
Report is 6 commits behind head on master.

Files Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 66.66% 2 Missing and 1 partial ⚠️
...jenkinsci/plugins/oic/OicJsonWebTokenVerifier.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #311      +/-   ##
============================================
- Coverage     73.35%   73.32%   -0.04%     
  Complexity      211      211              
============================================
  Files            10       10              
  Lines           882      881       -1     
  Branches        124      124              
============================================
- Hits            647      646       -1     
  Misses          172      172              
  Partials         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez
Copy link
Contributor

LGTM

@michael-doubez michael-doubez merged commit 6b37ce1 into jenkinsci:master May 1, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants