-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer docs #410
Add developer docs #410
Conversation
This creats a working but limited ADFS setup. Still missing: groups and refresh tokens
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
============================================
- Coverage 74.18% 74.16% -0.02%
- Complexity 257 261 +4
============================================
Files 15 15
Lines 1007 1022 +15
Branches 145 147 +2
============================================
+ Hits 747 758 +11
- Misses 187 191 +4
Partials 73 73 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, that is a lot of detail, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition
Adds some developer docs, with howto use the OpenID Connect conformance tests, as well as howto setup an ADFS instance for testing.
Testing done
the docs for ADFS where taken as I performed the steps. I could authenticate to Jenkins and retreive groups.
if viewing rendered markdown the image references do not work as GH is attempting to use the branchname from the origin not the fork. so in that case look at https://github.com/jtnord/oic-auth-plugin/blob/add-developer-docs/docs/developer/AD-FS/setup-test-instance.md for a rendered view.
Submitter checklist