Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass the correct argument to create the group filed JMESPath #492

Merged
merged 1 commit into from
Dec 24, 2024
Merged

pass the correct argument to create the group filed JMESPath #492

merged 1 commit into from
Dec 24, 2024

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Dec 23, 2024 •
edited
Loading

The method argument was passed to create the JMESPath when creating the groupsFieldName, however this was not a string that had been passed through Util.fixEmptyAndTrim which caused exceptions to be logged when not using groups

relates to #461

Testing done

None.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord
pass the correct argument to create the JMESPath
e4f2c83 
The filed was passed to create the JMESPath when creating the groupsFieldName, however this was not a string that had been passed through `Util.fixEmptyAndTrim` which caused exceptions to be logged when not using groups
@jtnord jtnord requested a review from a team as a code owner December 23, 2024 15:57
@jtnord jtnord added the bug label Dec 23, 2024
@jtnord jtnord changed the title pass the correct argument to create the JMESPath pass the correct argument to create the group filed JMESPath Dec 23, 2024
@jtnord jtnord mentioned this pull request Dec 23, 2024
Closed
michael-doubez
michael-doubez approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@michael-doubez michael-doubez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-doubez michael-doubez merged commit d4c54f1 into master Dec 24, 2024
20 checks passed
@michael-doubez michael-doubez deleted the fix-group-jmespath-creation branch December 24, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-doubez michael-doubez michael-doubez approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtnord @michael-doubez