Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChangeDetailsCard #376

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

stuartrowe
Copy link
Contributor

@stuartrowe stuartrowe commented Mar 24, 2024

Prototype for a ChangeDetailsCard on the pipeline overview graph.

Fixes #375

image

Testing done

Submitter checklist

@timja timja added the enhancement New feature or request label Mar 24, 2024
@timja
Copy link
Member

timja commented Mar 24, 2024

I think this needs some sort of cap:

(that's a truncated screenshot showing a lot of changes)

image

Jenkins core handles it by showing less detail:

image

@stuartrowe
Copy link
Contributor Author

Absolutely. I think the cards need to support collapsing too. I will attempt that in a separate PR.

@mr-remington
Copy link
Contributor

@stuartrowe any updates? I was getting ready to work on the same view though I had a different approach. For us the pipeline card is too small(massive parallel pipeline) so I was gonna tweak it so that the Details card would be positioned on top of pipeline and give the pipeline card full width. This would directly interfere with your work here

@stuartrowe
Copy link
Contributor Author

stuartrowe commented Jun 21, 2024

I haven't had a chance to revisit. Don't worry about interfering with this prototype if you want to explore your proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new ChangeDetailsCard to the pipeline overview graph
3 participants