-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish incrementals #255
Publish incrementals #255
Conversation
…s which were using the latest UC version
@@ -26,6 +25,7 @@ | |||
<goal>shade</goal> | |||
</goals> | |||
<configuration> | |||
<createDependencyReducedPom>false</createDependencyReducedPom> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to work around mojohaus/flatten-maven-plugin#100.
…add failFast, and no need for timestamps
@@ -142,6 +139,7 @@ public void testWithUrl() throws Throwable { | |||
} | |||
} | |||
|
|||
@Ignore("TODO broken by https://github.com/jenkinsci/active-directory-plugin/releases/tag/active-directory-2.17; figure out how to pin a version") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of Incrementals in jenkinsci/active-directory-plugin#102 seems to have broken these two tests. Anyway no tests here ought to be drawing plugin versions from the update center. (Perhaps we should simply remove this mode and only support -war
? I do not know of anyone who actually uses it.)
We have an issue with Artifactory sponsorship costs, and I would recommend to avoid adding new Incrementals Pipelines until we resolve it. It is important especially for components with Dependabot which would generate a lot of deployments. CC @MarkEWaite |
@oleg-nenashev well this component is not producing that much compared to Jenkins core or the many incrementalified plugins, and I actually do need incremental versions of this for consumption from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will soon investigate ways to reduce the hosting costs that JFrog has been covering for the Jenkins project. I don't expect this addition will significantly change those costs. I recommend proceeding with it.
No description provided.