-
Notifications
You must be signed in to change notification settings - Fork 168
Commit
… build history panel (#187) * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon * Remove references to non-existent error.png icon --------- Co-authored-by: Mark Waite <[email protected]> Co-authored-by: Alexander Brandes <[email protected]>
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,11 +116,10 @@ public PromotionProcess getProcess() { | |
|
||
/** | ||
* Gets the icon that should represent this promotion (that is potentially attempted but failed.) | ||
* @param size size of the icon, will be used in the icon path | ||
* @return Path to the icon in resources | ||
* @return Path to the SVG icon in resources or l:icon class name | ||
*/ | ||
@NonNull | ||
public String getIcon(String size) { | ||
public String getIcon() { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
MarkEWaite
Author
Contributor
|
||
String baseName; | ||
|
||
PromotionProcess p = getProcess(); | ||
|
@@ -130,7 +129,7 @@ public String getIcon(String size) { | |
} else { | ||
Promotion l = getLast(); | ||
if (l!=null && l.getResult()!= Result.SUCCESS) { | ||
return Jenkins.RESOURCE_PATH+"/images/"+size+"/error.png"; | ||
return "icon-red"; | ||
} | ||
baseName = p.getIcon(); | ||
} | ||
|
This change broke the delivery-pipeline-plugin:
java.lang.NoSuchMethodError: 'java.lang.String hudson.plugins.promoted_builds.Status.getIcon(java.lang.String)'
at PluginClassLoader for delivery-pipeline-plugin//se.diabol.jenkins.pipeline.domain.status.promotion.PromotionStatusProvider$PromotionStatusWrapper.getIcon(PromotionStatusProvider.java:129)
at PluginClassLoader for delivery-pipeline-plugin//se.diabol.jenkins.pipeline.domain.status.promotion.PromotionStatusProvider.buildNewPromotionStatus(PromotionStatusProvider.java:82)
at PluginClassLoader for delivery-pipeline-plugin//