Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore java8 compatability - alternative #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Aug 4, 2022

See JENKINS-69229.

downstream of jenkinsci/pom#297 and an alternative to #106

Submitter checklist

  • JIRA issue is well described
  • Appropriate autotests or explanation to why this change has no tests

@jtnord jtnord requested a review from a team as a code owner August 4, 2022 11:40
@jtnord jtnord changed the title resore java8 compatability restore java8 compatability - alternative Aug 4, 2022
@@ -6,7 +6,7 @@
<parent>
<groupId>org.jenkins-ci</groupId>
<artifactId>jenkins</artifactId>
<version>1.83</version>
<version>1.85-20220804.113638-2</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream has no incremental publishing - this was deployed locally and would need updating to a release when it is made (if accepted)

Suggested change
<version>1.85-20220804.113638-2</version>
<version>1.85</version>

@kuisathaverat
Copy link
Contributor

I do not see a strong reason to restore Java 8 compatibility.

@daniel-beck
Copy link
Member

daniel-beck commented Aug 4, 2022

@kuisathaverat Could you confirm that you neither want to

  • restore Java 8 compatibility
  • raise the Jenkins dependency of this plugin to 2.357+

I.e. you insist this plugin be distributed to folks on the current LTS line for which we claim Java 8 compatibility? (We don't have the infra set up to distinguish by Java dependency -- and adding it wouldn't be quick, Jenkins doesn't tell the update site like it tells us about the core version.)

@kuisathaverat
Copy link
Contributor

the plugins version is suspended from the update center so nobody will install it, the next version will bump the Jenkins Core to the next LTS with Java 11 only support, Are there any issue is not covered by theese measures?

@daniel-beck
Copy link
Member

@kuisathaverat If there's not going to be a new release before you raise the core dependency to the next LTS baseline newer than 2.357, that's should also work out (suspending plugins for a while has come back to bite us in the past, but if we don't release the BOM or similar it should work out).

@kuisathaverat
Copy link
Contributor

jenkinsci/trilead-api-plugin#55 set the base line on 2.361 so no new releases with support for Java 8

@jtnord
Copy link
Member Author

jtnord commented Aug 18, 2022

@kuisathaverat would you please move forward with either the restoration of java8 in this project or jenkinsci/trilead-api-plugin#55?

@kuisathaverat
Copy link
Contributor

kuisathaverat commented Aug 18, 2022

As I commented before #107 (comment) I will merge jenkinsci/trilead-api-plugin#55 next week.

@kuisathaverat
Copy link
Contributor

I think this PR can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants