Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copm one step build and test #8

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jenniferlianne
Copy link
Owner

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Jennifer Bell added 2 commits November 12, 2024 10:54
Primary Change: The openapi doc generation script had a
reference to the @hyperledger package prefix hardcoded.

This meant that packages that were updated to
@hyperledger-cacti still had an ampersand in their path,
resulting in them not being included in the generated
documentation.

Signed-off-by: Jennifer Bell <[email protected]>
Primary change:

Implements COPM primitives for Corda as a cacti
plugin.  The implementation follows the model of
the Corda ledger connector plugin, where a
typescript pass-through implementation is
registered on the plugin server, and commands are
implemented on a separate grpc server in the
Kotlin Spring framework.

Secondary changes:

- The lock claim protobuf structure was updated
to reduce the number of parameters.
- A no-op endpoint was added, per project
specification
- The format of the inter-network command for
requesting the status of a pledge varies by
remote network type and asset.  Adds a function to
the typescript interop configuration  interface to
supply the appropriate command given
the remote network and asset.
- Adds test package to test combinations of
network types
- Updates CI script to use new testing
framework
- Updates linter ignore to include weaver build
directories, allowing yarn lint to pass on
a system where weaver libraries have been built.
Also excludes docs directory to avoid linting
minified js from documentation packages.

Signed-off-by: Jennifer Bell <[email protected]>
@jenniferlianne jenniferlianne force-pushed the copm_one_step_build_and_test branch from d4b0399 to 7ec9b81 Compare November 15, 2024 13:55
part-way

partly working

partly working

working

working

typo
@jenniferlianne jenniferlianne force-pushed the copm_one_step_build_and_test branch from 7ec9b81 to 8609737 Compare November 15, 2024 13:56
@jenniferlianne jenniferlianne force-pushed the copm_one_step_build_and_test branch from 5dc8bac to 2bd7a0d Compare November 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant