Skip to content

Commit

Permalink
remove custom page styles, add props to fix page fill
Browse files Browse the repository at this point in the history
  • Loading branch information
jenny-s51 committed Aug 6, 2024
1 parent a0f7809 commit 1a3d1b5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
13 changes: 9 additions & 4 deletions packages/demo-app-ts/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ class App extends React.Component<{}, AppState> {
<Route
path={`/${demo.id}-nav-link/${subDemo.id}-nav-link`}
render={() => (
<PageSection style={{ zIndex: 2 }} id={`/${demo.id}-nav-link/${subDemo.id}-nav-link`}>
<PageSection
isFilled
hasBodyWrapper={false}
style={{ zIndex: 2 }}
id={`/${demo.id}-nav-link/${subDemo.id}-nav-link`}
>
{React.createElement(subDemo.componentType)}
</PageSection>
)}
Expand All @@ -87,7 +92,7 @@ class App extends React.Component<{}, AppState> {
<Route
path={`/${demo.id}-nav-link`}
render={() => (
<PageSection style={{ zIndex: 2 }} id={`/${demo.id}-page-section`}>
<PageSection isFilled hasBodyWrapper={false} style={{ zIndex: 2 }} id={`/${demo.id}-page-section`}>
{React.createElement(demo.componentType)}
</PageSection>
)}
Expand All @@ -101,7 +106,7 @@ class App extends React.Component<{}, AppState> {
<Route
path="/"
render={() => (
<PageSection style={{ zIndex: 2 }} id={`/${defaultDemo.id}-page-section`}>
<PageSection isFilled hasBodyWrapper={false} style={{ zIndex: 2 }} id={`/${defaultDemo.id}-page-section`}>
{React.createElement(defaultDemo.componentType)}
</PageSection>
)}
Expand Down Expand Up @@ -207,7 +212,7 @@ class App extends React.Component<{}, AppState> {

return (
<Router>
<Page masthead={AppHeader} sidebar={AppSidebar} isManagedSidebar mainContainerId={this.pageId}>
<Page isContentFilled masthead={AppHeader} sidebar={AppSidebar} isManagedSidebar mainContainerId={this.pageId}>
{this.getPages()}
</Page>
</Router>
Expand Down
6 changes: 0 additions & 6 deletions packages/demo-app-ts/src/Demo.css
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,3 @@
.pf-v6-c-toolbar__content.pf-m-hidden {
display: none;
}

.pf-v6-c-page__main-container,
.pf-v6-c-page__main-section,
.pf-v6-c-page__main-body {
height: 100%;
}

0 comments on commit 1a3d1b5

Please sign in to comment.