Skip to content

Commit

Permalink
Fix #75 audio:not([controls]) display
Browse files Browse the repository at this point in the history
  • Loading branch information
mirisuzanne committed Feb 1, 2021
1 parent 9defa91 commit 5b79a04
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
12 changes: 6 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,26 @@

## UNRELEASED

- Remedies: Add basic `[hidden]` remedy
- [Remedy] New: Add basic `[hidden]` remedy
to fix unintentional `display` overrides
- [Remedy] Fix: Audio without `[controls]` remains hidden by default

## v0.1.0-beta.2 - 9/18/2019

- Reminders: Comment out reminders,
- [Reminder] Fix: Comment out reminders,
so that authors have to explicitly opt-in
case-by-case.
- Docs: Add inline documentation comments
- [Docs] Add inline documentation comments
(marked with `@docs`)
using [Doxray](https://github.com/himedlooff/doxray)
and YAML format.
- Docs: Typo fixes
- NPM: Exclude irrelevant files from npm releases
- [NPM] Exclude irrelevant files from npm releases

## v0.1.0-beta.1 - 9/12/2019

This is an incomplete set of remedies,
and still very likely to change -
but you have to start somewhere.
but we have to start somewhere.

- Move stylsheets into `css/` directory
- Organize the existing proposed & discussed remedies into three categories:
Expand Down
7 changes: 4 additions & 3 deletions css/remedy.css
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,10 @@ body { margin: 0; }


/* @docs
label: Hidden
label: Hidden Attribute
note: |
Maintain `hidden` behaviour
when overriding `display` defaults.
Maintain `hidden` behaviour when overriding `display` values.
category: global
*/
Expand Down Expand Up @@ -123,6 +122,7 @@ note: |
1. Block display is usually what we want
2. Remove strange space-below in case authors overwrite the display value
3. Responsive by default
4. Audio without `[controls]` remains hidden by default
category: embedded elements
*/
Expand All @@ -131,6 +131,7 @@ img, svg, video, canvas, audio, iframe, embed, object {
vertical-align: middle;
max-width: 100%;
}
audio:not([controls]) { display:none; }


/* @docs
Expand Down

0 comments on commit 5b79a04

Please sign in to comment.