Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL version parsed incorrectly for Ubuntu 18.04/PSQL 10.9 #4

Open
walecome opened this issue Jun 24, 2019 · 0 comments · May be fixed by #5
Open

PostgreSQL version parsed incorrectly for Ubuntu 18.04/PSQL 10.9 #4

walecome opened this issue Jun 24, 2019 · 0 comments · May be fixed by #5

Comments

@walecome
Copy link

On my Ubuntu 18.04 machine the pg_config --version output is the following:
PostgreSQL 10.9 (Ubuntu 10.9-0ubuntu0.18.04.1)

Minor/major versions will be parsed to
9 (Ubuntu 10.9-0ubuntu0.18.04.1)
10 (Ubuntu 10.9-0ubuntu0.18.04.1)

which in turns makes the build fail. See sources.mk for Postgres module
pitkali added a commit to pitkali/v8-jsshell that referenced this issue Jun 28, 2019
@pitkali
More robust PostgreSQL version detection
7231469 
The version check only worked with pg_config reporting 3-component
version number *and* no extra information. This does not work with libpq
as available in Ubuntu repositories, which both (a) only reports major
and minor version components, and (b) adds more information in the
parens afterwards.

But only major and minor are actually used, so just read those in and
slurp the rest of the line.

Fixes jensl#4.
@pitkali pitkali linked a pull request Jun 28, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More robust PostgreSQL version detection pitkali/v8-jsshell
1 participant
@walecome