More robust PostgreSQL version detection #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version check only worked with pg_config reporting 3-component version number *and* no extra information. This does not work with libpq as available in Ubuntu repositories, which both (a) only reports major and minor version components, and (b) adds more information in the parens afterwards. But only major and minor are actually used, so just read those in and slurp the rest of the line. Fixes jensl#4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version check only worked with pg_config reporting 3-component
version number and no extra information. This does not work with libpq
as available in Ubuntu repositories, which both (a) only reports major
and minor version components, and (b) adds more information in the
parens afterwards.
But only major and minor are actually used, so just read those in and
slurp the rest of the line.
Fixes #4.