add --commit-label option #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
commented
Feb 19, 2019
asv/repo.py
Outdated
| if hash is None: | ||
| return datetime.datetime.now() | ||
| self._raise_error() | ||
| return datetime.datetime.now().isoformat() |
There was a problem hiding this comment.
don't know what's that for, but for the benchmarks to be saved it has to be json compliant.
There was a problem hiding this comment.
asv publish plots usually use commit time as an x-axis.
|
will probably have to add a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal: save results when benchmarking against existing environment.
Add a
--commit-labeloption to theruncommand. If provided, will save the result using it as if it were the commit hash (although can be anything).ping @pierreglaser