Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Isolation from Revit #296

Draft
wants to merge 115 commits into
base: dev
Choose a base branch
from
Draft

Component Isolation from Revit #296

wants to merge 115 commits into from

Conversation

Nice3point
Copy link
Collaborator

@Nice3point Nice3point commented Oct 6, 2024

Summary of the Pull Request

What is this about:

Update the Solution structure to provide more flexible development and isolate projects from each other.

A new ability to create plugins based on LookupEngine #278

Description:

  • Net 9 support
  • Solution .slnx format support
  • Isolated LookupEngine
  • Isolated UI framework
  • Engine tests and benchmarks
  • Full independence of critical components from Revit
  • Revit integration

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • All exceptions are caught in async void blocks
  • Some commons utils moved to Nuget

@Nice3point Nice3point added build 🔥 Some changes or issues related to build infrastructure improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change priority 🚩 An issue or change that has priority labels Oct 6, 2024
@Nice3point Nice3point added this to the 2026.0.0 milestone Oct 6, 2024
@Nice3point Nice3point self-assigned this Oct 6, 2024
@Nice3point Nice3point linked an issue Jan 16, 2025 that may be closed by this pull request
@jeremytammik
Copy link
Owner

jeremytammik commented Jan 22, 2025

dear roman, @Nice3point , i suggest you do not use the term Revit 2026. just say future release, or preview release, or something until the final product has been publicly released. using that term might be on the limits of violating the NDA. by the way, i had a request today from the development team for an autodesk internal version of RevitLookup for the preview release. would you be capable and willing to provide that to them? thank you!

@Nice3point
Copy link
Collaborator Author

Nice3point commented Jan 22, 2025

@jeremytammik already sent the pre-release builds to Weiwei's email, hope he got it. I don't think I mentioned 26 anything in this PR, except for Milestone, no problem I will remove it

@Nice3point Nice3point removed this from the 2026.0.0 milestone Jan 22, 2025
@jeremytammik
Copy link
Owner

wow, great, i'm sure that made him happy. oh, i just saw the words in the github email notification. i don't know where they came from. thank you for taking such good care!

@Nice3point
Copy link
Collaborator Author

most likely you have received a notification that the “Code quality” Pipeline has failed, its about JetBrains service, not Revit. For now, it will always fail with an error because the license has expired. We have requested a renewal from jetBrains

@Nice3point
Copy link
Collaborator Author

@jeremytammik Jeremy if you has some time, could you please verify a Card description for tools ?
https://github.com/jeremytammik/RevitLookup/blob/dev_environment/source/RevitLookup.UI.Playground/Mockups/ViewModels/Dashboard/MockDashboardViewModel.cs#L42

It will be displaying on the dashboard:
image

@jeremytammik
Copy link
Owner

jeremytammik commented Jan 22, 2025

you mean run it and Explore and analyze the model's visual representation? ... how should that be done?

@jeremytammik
Copy link
Owner

oh i think i understand what you mean now. you mean proof read the descriptions that you have written for each card? sure, i will do that immediately.

@jeremytammik
Copy link
Owner

jeremytammik commented Jan 22, 2025

done, PR #306 submitted.

@Nice3point
Copy link
Collaborator Author

Nice3point commented Jan 22, 2025

Oh thanks, but Schemata uses in the Revit api? i guess no) https://www.revitapidocs.com/2016/9817e7db-8367-ea4e-1769-0488f3faa37f.htm

@jeremytammik
Copy link
Owner

jeremytammik commented Jan 22, 2025

nope. it is the officially correct plural of schema, though, afaik. but feel free to use schemas if you prefer. nobody will complain. i will feel the pain, but that is just poor little me.

@Nice3point
Copy link
Collaborator Author

Nice3point commented Jan 22, 2025

image
so both are possible)

https://english.stackexchange.com/questions/77764/plural-form-of-schema

The Greek schemata is mostly found in academic writing (e.g. experimental schemata), whereas the anglicized schemas is used freely in both technical and more general discourse (e.g. database access schemas).

@Nice3point
Copy link
Collaborator Author

@SergeyNefyodov History added: https://github.com/jeremytammik/RevitLookup/blob/dev_environment/source/RevitLookup.Abstractions/Services/Decomposition/IDecompositionService.cs#L8

So you can rework FamilySizeTableEditDialog and other dialogs. Now we have a navigation context. Currently FamilySizeTable removed from the new codebase, because it has a lot of Revit dependencies, we need abstractions, but original files store in the RevitLookup.Obsolete project.

New menu registration format:
https://github.com/jeremytammik/RevitLookup/blob/dev_environment/source/RevitLookup/Core/Decomposition/Descriptors/BoundingBoxXyzDescriptor.cs#L139

var decompositionService = serviceProvider.GetRequiredService<IDecompositionService>();
decompositionService.DecompositionStackHistory //Find parent context to pass to your method

No documentation for now, will be later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 Some changes or issues related to build infrastructure improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change priority 🚩 An issue or change that has priority
Projects
Status: 🏗 In progress
3 participants