removed obsolete API usage: reduced warning count from 71 to 67

jeremytammik · Aug 19, 2014 · 9a14a43 · 9a14a43
1 parent b193899
commit 9a14a43
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 8 deletions.
diff --git a/BuildingCoder/BuildingCoder/CmdCategories.cs b/BuildingCoder/BuildingCoder/CmdCategories.cs
@@ -32,8 +32,14 @@ DefinitionFile sharedParametersFile
       DefinitionGroup group = sharedParametersFile
         .Groups.Create( "Reinforcement" );
 
-      Definition def = group.Definitions.Create(
-        "ReinforcementParameter", ParameterType.Text );
+      //Definition def = group.Definitions.Create( // 2014
+      //  "ReinforcementParameter", ParameterType.Text );
+
+      ExternalDefinitonCreationOptions opt 
+        = new ExternalDefinitonCreationOptions( 
+          "ReinforcementParameter", ParameterType.Text );
+
+      Definition def = group.Definitions.Create( opt ); // 2015
 
       List<BuiltInCategory> bics
         = new List<BuiltInCategory>();

diff --git a/BuildingCoder/BuildingCoder/CmdMepElementShape.cs b/BuildingCoder/BuildingCoder/CmdMepElementShape.cs
@@ -9,6 +9,7 @@
 #region Namespaces
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Text.RegularExpressions;
 using Autodesk.Revit.ApplicationServices;
 using Autodesk.Revit.Attributes;
@@ -79,7 +80,14 @@ public static string GetElementShape( Element e )
         {
           // simple case, no need to use regular expression
 
-          string size = e.get_Parameter( "Size" )
+          //string size = e.get_Parameter( "Size" ) // 2014
+          //  .AsString();
+
+          Debug.Assert(
+            1 == e.GetParameters( "Size" ).Count,
+            "expected only one parameters named 'Size'" );
+
+          string size = e.LookupParameter( "Size" ) // 2015
             .AsString();
 
           if( size.Split( 'x' ).Length == 2 )

diff --git a/BuildingCoder/BuildingCoder/CmdRollingOffset.cs b/BuildingCoder/BuildingCoder/CmdRollingOffset.cs
@@ -443,9 +443,12 @@ FamilySymbol symbol
 
           // Create rolling offset pipe segment
 
-          pipe = doc.Create.NewPipe( con0.Origin,
+          pipe = doc.Create.NewPipe( con0.Origin, // 2014
             con1.Origin, pipe_type_standard );
 
+          //pipe = Pipe.Create( doc, pipe_type_standard.Id, con0.Origin, // 2015
+          //  con1.Origin );
+
           pipe.get_Parameter( bipDiameter )
             .Set( diameter );
 

diff --git a/BuildingCoder/BuildingCoder/JtRevision.cs b/BuildingCoder/BuildingCoder/JtRevision.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics;
 using Autodesk.Revit.DB;
 
 namespace BuildingCoder
@@ -18,7 +19,15 @@ class JtRevision
     /// </summary>
     Parameter _p( string parameter_name )
     {
-      return _e.get_Parameter( parameter_name );
+      //return _e.get_Parameter( parameter_name ); // 2014
+
+      Debug.Assert( 
+        1 == _e.GetParameters( parameter_name ).Count,
+        string.Format( 
+          "expected only one parameters named '{0}'", 
+          parameter_name ) );
+
+      return _e.LookupParameter( parameter_name ); // 2015
     }
 
     /// <summary>

diff --git a/BuildingCoder/BuildingCoder/Properties/AssemblyInfo.cs b/BuildingCoder/BuildingCoder/Properties/AssemblyInfo.cs
@@ -35,6 +35,7 @@
 // 2014-04-14 2015.0.109.0 migrated to Revit 2015
 // 2014-05-14 2015.0.110.0 CmdViewsShowingElements
 // 2014-07-21 2015.0.110.1 AddFaceBasedFamilyToLinks
+// 2014-08-19 2015.0.110.2 remove obsolete API usage: reduced warning count from 71 to 67
 // 
-[assembly: AssemblyVersion( "2015.0.110.1" )]
-[assembly: AssemblyFileVersion( "2015.0.110.1" )]
+[assembly: AssemblyVersion( "2015.0.110.2" )]
+[assembly: AssemblyFileVersion( "2015.0.110.2" )]
diff --git a/BuildingCoder/BuildingCoder/Util.cs b/BuildingCoder/BuildingCoder/Util.cs
@@ -901,8 +901,15 @@ FilteredElementCollector collector
       {
         if( f.Name.Equals( familyName ) )
         {
-          foreach( FamilySymbol symbol in f.Symbols )
+          //foreach( FamilySymbol symbol in f.Symbols ) // 2014
+
+          ISet<ElementId> ids = f.GetFamilySymbolIds(); // 2015
+
+          foreach( ElementId id in ids )
           {
+            FamilySymbol symbol = doc.GetElement( id ) 
+              as FamilySymbol;
+
             if( symbol.Name == symbolName )
             {
               return symbol;