Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for normal diodes #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rastersoft
Copy link
Contributor

This patch adds an extra parameter, --normal-diodes, that uses
normal, pass-through 1N4148 diodes instead of SMD-mounted ones.

@rastersoft rastersoft force-pushed the allow_normal_diodes branch from b87cf30 to 3a09dda Compare July 9, 2022 21:44
This patch adds an extra parameter, --normal-diodes, that uses
normal, pass-through 1N4148 diodes instead of SMD-mounted ones.
@rastersoft rastersoft force-pushed the allow_normal_diodes branch from 3a09dda to 8761222 Compare July 10, 2022 21:27
@jeroen94704
Copy link
Owner

While I like the option for through-hole diodes, as well as your pull-request to make the switch traces optional, I think I need a better way to handle switches like these. Doing it this way quickly gets out of hand when adding more options, with the code littered with if-statements. Not sure how to approach this yet, but I'll leave both this pull-request as well as #19 open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants