Skip to content

Commit

Permalink
Ellided cells a bit more visible (skrub-data#1085)
Browse files Browse the repository at this point in the history
  • Loading branch information
GaelVaroquaux authored Sep 24, 2024
1 parent 6bacc73 commit d5db4ca
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 7 deletions.
19 changes: 15 additions & 4 deletions skrub/_reporting/_data/templates/dataframe-sample.css
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,27 @@ table:not(:focus-within):not(:has(:active)) .table-cell[data-is-active] {

/* The gap separating the head and the tail of the table */

#report .ellided-table-part {
border: 1px solid white;
#report .ellided-table-part,
#report .ellided-table-part td {
border: 2px dashed var(--mediumg);
text-align: center;
border-top: 0;
border-bottom: 0;
background: inherit;
}

#report table:has([data-role="index-level-value"]) .ellided-table-part:first-child{
text-align: right;
#report .ellided-table-part td {
padding: var(--tiny);
}

#report .ellipsis-icon {
display: flex;
flex-direction: column;
max-height: var(--large);
}

#report table:has([data-role="index-level-value"]) .ellided-table-part td:first-child .ellipsis-icon * {
align-self: flex-end;
}

.table-bar-wrapper {
Expand Down
5 changes: 2 additions & 3 deletions skrub/_reporting/_data/templates/dataframe-sample.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,16 @@
>
{% for table_part in summary["sample_table"]["parts"] %}
{% if table_part["name"] == "ellipsis" %}
<tbody>
<tbody class="ellided-table-part">
<tr>
{% for i in range(summary["sample_table"]["start_j"], summary["sample_table"]["stop_j"])%}
<td
class="ellided-table-part"
{% if i >= 0%}
data-manager="FilterableColumn"
data-column-idx="{{ i }}"
data-role="ellipsis"
{% endif %}
></td>
><div class="ellipsis-icon">{% include "icons/three-dots-vertical.svg" %}</div></td>
{% endfor %}
</tr>
</tbody>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit d5db4ca

Please sign in to comment.