Add try_get_or_insert_mut #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rj00a
pushed a commit
to valence-rs/valence
that referenced
this pull request
Sep 3, 2023
# Objective - Follow on from #510 by adding the ability to write and delete chunks in anvil files. # Solution - Users can change the compression method and whether to write oversized chunks, in case they want to write anvil files compatible with older versions of Minecraft. - `LruCache::try_get_or_insert_mut` is something I have [pull requested](jeromefroe/lru-rs#178) to `lru`, we can switch to that once it's merged.
|
Thanks for the contribution @Earthcomputer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix issues with
try_get_or_insertdocumentation and simplify its implementation.