Constructor & case type-checking #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liesnikov
force-pushed
the
constructor-type-checking
branch
from
2de4ae7 to
3f6c9e4
Compare
|
smarter conversion is hard, see: https://github.com/jespercockx/agda-core/compare/smarter-type-conversion-for-dt (3ebba92) |
liesnikov
force-pushed
the
constructor-type-checking
branch
from
3f6c9e4 to
a621b41
Compare
liesnikov
force-pushed
the
constructor-type-checking
branch
3 times, most recently
from
847d4dd to
762af44
Compare
liesnikov
force-pushed
the
constructor-type-checking
branch
from
f9ff6db to
0134d11
Compare
due to indexing issues had to change the typing rule too, maybe there's a way around it
this simplifies the typechecker of constructors a lot before rebase this correspnded to switching from master to alllookup branch for the scope library
move inferVar out of the mutual block break lines in a slightly more sensible way
liesnikov
force-pushed
the
constructor-type-checking
branch
from
0134d11 to
6ce499c
Compare
The only unsolved meta is in the context extension of conversion checker for the *sort* of the scrutinee. Which shouldn't matter because we never use sorts of the variables from the context. Nevertheless, have to find a way to fill it in in a way that makes sense.
liesnikov
force-pushed
the
constructor-type-checking
branch
from
7814537 to
6b02481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses jespercockx/scope#4 branch of the scope library because allLookup turned out to be a very stubborn function to implement, requiring a lot of unfolds