Merge pull request foundation#10522 from SassNinja/feature/dropdown-p…

…osition Original dropdown position & alignment and CSS classes
jessedoyle · Aug 17, 2017 · 191ee59 · 191ee59
2 parents 95e4850 + 2dfd719
commit 191ee59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/js/foundation.dropdown.js b/js/foundation.dropdown.js
@@ -105,7 +105,9 @@ class Dropdown extends Positionable {
    * @private
    */
   _setPosition() {
+    this.$element.removeClass(`has-position-${this.position} has-alignment-${this.alignment}`);
     super._setPosition(this.$currentAnchor, this.$element, this.$parent);
+    this.$element.addClass(`has-position-${this.position} has-alignment-${this.alignment}`);
   }
 
   /**

diff --git a/js/foundation.positionable.js b/js/foundation.positionable.js
@@ -40,6 +40,8 @@ class Positionable extends Plugin {
     this.triedPositions = {};
     this.position  = this.options.position === 'auto' ? this._getDefaultPosition() : this.options.position;
     this.alignment = this.options.alignment === 'auto' ? this._getDefaultAlignment() : this.options.alignment;
+    this.originalPosition = this.position;
+    this.originalAlignment = this.alignment;
   }
 
   _getDefaultPosition () {
@@ -122,6 +124,12 @@ class Positionable extends Plugin {
         $anchorDims = Box.GetDimensions($anchor);
 
 
+    if (!this.options.allowOverlap) {
+      // restore original position & alignment before checking overlap
+      this.position = this.originalPosition;
+      this.alignment = this.originalAlignment;
+    }
+
     $element.offset(Box.GetExplicitOffsets($element, $anchor, this.position, this.alignment, this._getVOffset(), this._getHOffset()));
 
     if(!this.options.allowOverlap) {