Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hosting service definition for Azure DevOps Server #4079

Closed

Conversation

chuseman
Copy link

  • PR Description

This adds a new service definition for Azure DevOps Server (the on-prem version of Azure DevOps Service). The service definition URLs are also slightly different from its cloud-hosted sibling.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@chuseman chuseman force-pushed the add-azure-devops-server branch from cece62c to 711e65a Compare November 26, 2024 21:14
Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesseduffield jesseduffield added the enhancement New feature or request label Jan 8, 2025
@jesseduffield
Copy link
Owner

LGTM but those conflicts will need to be resolved first

@chuseman
Copy link
Author

chuseman commented Jan 8, 2025

Looks like the conflict is from #3954 being merged last week which solves the same issue by just allowing another https URL pattern for the azuredevops prefix.

Though that doesn't address ssh urls, it'll work for my use so I might as well close this PR.

@chuseman chuseman closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants