compatible with python-2.6 #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezh
force-pushed
the
compatible-with-pyhton-2.6
branch
2 times, most recently
from
9e32999 to
a5044c6
Compare
Fixes two issues in generators/xml.py when using python-2.6. The main problem is caused by incompatible between xml.etree.ElementTree-1.2 (used by pyhton-2.6) and xml.etree.ElementTree-1.3 (used by python-2.7). + ElementTree.register_namespace(prefix, uri) Workaround by: ElementTree._namespace_map[uri] = prefix This solution is based on http://goo.gl/Z4Sjtq + ElementTree.write(file, encoding='utf-8', xml_declaration=True) Workaround by: ElementTree.write(file, encoding='UTF-8') This solution is based on http://goo.gl/8K88ow (pls check Olli's answer) Also replaces unittest by unittest2 which is compitable with python-2.6 and fixes the tests. Signed-off-by: Kai Zhang <[email protected]>
kylezh
force-pushed
the
compatible-with-pyhton-2.6
branch
from
a5044c6 to
a13225e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues in generators/xml.py when using python-2.6.
The main problem is caused by incompatible between xml.etree.ElementTree-1.2
(used by pyhton-2.6) and xml.etree.ElementTree-1.3 (used by python-2.7).
ElementTree.register_namespace(prefix, uri)
Workaround by:
ElementTree._namespace_map[uri] = prefix
This solution is based on http://goo.gl/Z4Sjtq
ElementTree.write(file, encoding='utf-8', xml_declaration=True)
Workaround by:
ElementTree.write(file, encoding='UTF-8')
This solution is based on http://goo.gl/8K88ow (pls check Olli's answer)
Also replaces unittest by unittest2 which is compitable with python-2.6 and
fixes the tests.
Signed-off-by: Kai Zhang [email protected]