Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/internal resolve #4315

Merged
merged 20 commits into from
Aug 22, 2017
Merged

Feature/internal resolve #4315

merged 20 commits into from
Aug 22, 2017

Commits on Aug 21, 2017

  1. Pull resolve.sync code directly into default_resolver. (incomplete)

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    e19e946 View commit details
    Browse the repository at this point in the history

  2. Strip out extraneous core and caller dependencies.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    f8e02f3 View commit details
    Browse the repository at this point in the history

  3. Pull node-modules-path into codebase as well. (incomplete)

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    a80d267 View commit details
    Browse the repository at this point in the history

  4. Remove dependency on path-parse. Assume existence of path.parse (adde… 

    …d in v0.11.15).
    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    a4f2641 View commit details
    Browse the repository at this point in the history

  5. Use internal resolve within default_resolver.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    b0dd695 View commit details
    Browse the repository at this point in the history

  6. Adhere to linter constraints.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    5593152 View commit details
    Browse the repository at this point in the history

  7. Extend basic error type with code property.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    08bc70d View commit details
    Browse the repository at this point in the history

  8. Fix typing and remove extraneous options.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    942ddc7 View commit details
    Browse the repository at this point in the history

  9. Gather helper methods at end of resolveSync().

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    d10676a View commit details
    Browse the repository at this point in the history

  10. Rename "start" parameter to more obvious "basedir".

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    d15ec91 View commit details
    Browse the repository at this point in the history

  11. Avoid shadowing basedir variable.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    24e9b18 View commit details
    Browse the repository at this point in the history

  12. Inline loadNodeModulesSync() method.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    7e46c07 View commit details
    Browse the repository at this point in the history

  13. Clarify relative import vs node_modules.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    73ccd44 View commit details
    Browse the repository at this point in the history

  14. Use import instead of require.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    513f1d2 View commit details
    Browse the repository at this point in the history

  15. Small logic and formatting simplifications.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    e625b8a View commit details
    Browse the repository at this point in the history

  16. Use isBuiltinModule() to detect core modules. Restore use of moduleDi… 

    …rectory option.
    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    eb980f3 View commit details
    Browse the repository at this point in the history

  17. Remove package dependency on resolve.

    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    b046899 View commit details
    Browse the repository at this point in the history

  18. Make node_modules_paths available to resolver core logic, rather than… 

    … just default_resolver.
    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    580f0c8 View commit details
    Browse the repository at this point in the history

  19. Add standard header to node_modules_paths.js. Add adaptation note to … 

    …default_resolver.js.
    @tvald
    tvald committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    3313380 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2017

  1. Trim out unused options when calling nodeModulesPaths().

    @tvald
    tvald committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    de104b0 View commit details
    Browse the repository at this point in the history