fix: Use S3 Upload function instead of PutObjectCommand
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadenv
changed the title
Upload function instead of PutObjectCommandUpload function instead of PutObjectCommand
bestickley
approved these changes
Jul 13, 2024
|
Not sure if it was this change or what but since 4 was released my deployments are failing on next bucket deployment lambda stage with the error |
|
I've traced to the 4.0.0-beta.31 release, it works on 4.0.0-beta.30, so definitely this is the cause https://github.com/jetbridge/cdk-nextjs/releases/tag/v4.0.0-beta.31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started frequently facing this error when uploading S3 assets
RequestTimeout: Your socket connection to the server was not read from or written to within the timeout period. Idle connections will be closed.After some research, it seems like using the Upload constructor from @aws-sdk/lib-storage has more fault tolerance and better retry logic than the usual S3 PutObjectCommand.
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-lib-storage/
We have been running this change in production for a few weeks now and haven't had the error happen once since, so it seems to fix the issue.