feat(mqtt模拟器)：新增断开重试参数 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhou-hao
reviewed
Dec 12, 2023
| if (counter > options.getReconnectAttempts() && !isAlive()) { | ||
| dispose(); | ||
| } else { | ||
| Address localAddress = AddressManager.global().takeAddress(options.getLocalAddress()); |
| dispose(); | ||
| } else { | ||
| Address localAddress = AddressManager.global().takeAddress(options.getLocalAddress()); | ||
| Disposables.composite() |
There was a problem hiding this comment.
Disposables.composite().add()没啥意义，应该将Disposable添加到当前client中，在手动断开时，能取消重试任务。
| .flatMap(i -> Mono.<MqttClient>create(sink -> this.connect1(client, options, localAddress, sink))) | ||
| .subscribe(mqttClient -> { | ||
| log.info("客户端尝试重连:{},次数：{}", mqttClient.getId(), counter); | ||
| counter++; |
zhou-hao
reviewed
Dec 12, 2023
|
|
||
| disposables = Mono.delay(Duration.ofMillis(options.getReconnectInterval())) | ||
| .doOnNext(i -> fallback.run()) | ||
| .flatMap(i -> Mono.<MqttClient>create(sink -> this.connect1(client, options, this.address, sink, counter, fallback))) |
There was a problem hiding this comment.
这里重试不应该创建新的MqttClient，而是替换 当前对象中的 io.vertx.mqtt.MqttClient,否则可能无法发送消息。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.