Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(告警历史): 修改初始化告警历史元数据的方式 #585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(告警历史): 修改初始化告警历史元数据的方式 #585

wants to merge 1 commit into from

Conversation

PengyuDeng
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

zhou-hao
zhou-hao reviewed Nov 19, 2024
View reviewed changes
...c/main/java/org/jetlinks/community/rule/engine/service/ElasticSearchAlarmHistoryService.java
.addProperty("actualDesc", StringType.GLOBAL)
.addProperty("alarmConfigSource", StringType.GLOBAL)
.addProperty("bindings", new ArrayType().elementType(StringType.GLOBAL))
).subscribe();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

失败后无法感知，可能会导致后续数据写入错误。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.doOnError()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhou-hao zhou-hao zhou-hao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PengyuDeng @CLAassistant @zhou-hao