Allow viewing/downloading results across all batches #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user to stream all batch results from Salesforce in a single request to view combined results instead of having to view/download individual results, which is annoying when there are a lot of batches resolves #1082
Omit trace and debug logs from log buffer to avoid potentially sensitive data from showing up in bug tracking reports in case of a fatal error Improve http request logging to only show pertinent details
paustint
changed the title
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- apps/docs/docs/load/load.mdx: Language not supported
- apps/api/src/app/utils/response.handlers.ts: Evaluated as low risk
- apps/jetstream/src/app/components/core/AppInitializer.tsx: Evaluated as low risk
- libs/shared/data/src/lib/client-data-data-helper.ts: Evaluated as low risk
- libs/shared/ui-core/src/load-records-results/LoadRecordsBulkApiResultsTable.tsx: Evaluated as low risk
- libs/types/src/lib/ui/load-records-results-types.ts: Evaluated as low risk
- libs/shared/ui-core/src/mass-update-records/MassUpdateRecordsDeploymentRow.tsx: Evaluated as low risk
- libs/shared/client-logger/src/lib/client-logger.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
libs/features/load-records/src/components/load-results/LoadRecordsBulkApiResults.tsx:429
- The variable 'loadType' is used without being defined in the scope of the function 'handleDownloadOrViewRecords'. This could potentially cause a runtime error.
records = preparedData.data.filter((record) => (loadType !== 'DELETE' ? true : !!record.Id));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow viewing/downloading results across all batches
Allow user to stream all batch results from Salesforce in a single request to view combined results instead of having to view/download individual results, which is annoying when there are a lot of batches
resolves #1082