Data Table Fixes

[paustint]

shift+click on a row will select multiple rows

Navigating with keyboard on checkbox column, space can now be used to select the checkbox and focus does not go crazy

Triggering edit with the keyboard now works properly in all cases regardless of the field type

Focus is now trapped in the edit popover and focus is returned when the modal closes

The right-click context menu is now properly keyboard navigable

resolves #1103

Copilot reviewed 6 out of 20 changed files in this pull request and generated 2 suggestions.

Files not reviewed (14)

• .eslintrc.json: Language not supported
• apps/jetstream/src/main.scss: Language not supported
• package.json: Language not supported
• libs/ui/src/lib/popover/ContextMenu.tsx: Evaluated as low risk
• libs/ui/src/lib/data-table/SalesforceRecordDataTable.tsx: Evaluated as low risk
• libs/ui/src/lib/data-table/DataTableSubqueryRenderer.tsx: Evaluated as low risk
• libs/features/platform-event-monitor/src/PlatformEventMonitorEvents.tsx: Evaluated as low risk
• libs/features/deploy/src/utils/deploy-metadata.utils.tsx: Evaluated as low risk
• libs/ui/src/lib/data-table/data-table-utils.tsx: Evaluated as low risk
• libs/ui/src/lib/widgets/Tooltip.tsx: Evaluated as low risk
• libs/ui/src/lib/data-table/DataTableRenderers.tsx: Evaluated as low risk
• libs/ui/src/index.ts: Evaluated as low risk
• libs/ui/src/lib/form/date/DateGrid.tsx: Evaluated as low risk
• libs/ui/src/lib/data-table/DataTableEditors.tsx: Evaluated as low risk

Comments skipped due to low confidence (2)

libs/types/src/lib/ui/types.ts:388

• [nitpick] Consider using an enum for the 'type' property to ensure it only accepts specific values.

type: string;

libs/types/src/lib/ui/types.ts:389

• [nitpick] Consider using an enum for the 'icon' property to ensure it only accepts specific values.

icon: string;

Calling event.preventDefault() and event.stopPropagation() at the beginning of handleKeyDown might prevent default behavior for keys that are not handled by the function, such as the Tab key. Move these calls inside the conditional blocks where specific keys are handled.

Suggested change

	event.preventDefault();
	if (isEscapeKey(event)) { event.preventDefault(); event.stopPropagation(); onClose(); return; }

[socket-security]

Report too large to display inline

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Possible typosquat attack	npm/[email protected]	Did you mean: object~~.~~**-**assign	apps/docs/yarn.lock	⚠︎
Critical CVE	npm/[email protected]	CVE: GHSA-whpj-8f3w-67p5 vm2 Sandbox Escape vulnerability (CRITICAL) Affected versions: < 3.9.18 Patched version: 3.9.18	yarn.lock	⚠︎
Critical CVE	npm/[email protected]	CVE: GHSA-xj72-wvfv-8985 vm2 Sandbox Escape vulnerability (CRITICAL) Affected versions: < 3.9.16 Patched version: 3.9.16	yarn.lock	⚠︎
Critical CVE	npm/[email protected]	CVE: GHSA-ch3r-j5x3-6q2m vm2 Sandbox Escape vulnerability (CRITICAL) Affected versions: < 3.9.17 Patched version: 3.9.17	yarn.lock	⚠︎
Critical CVE	npm/[email protected]	CVE: GHSA-cchq-frgv-rjh5 vm2 Sandbox Escape vulnerability (CRITICAL) Affected versions: <= 3.9.19 Patched version: No patched versions	yarn.lock	⚠︎
Critical CVE	npm/[email protected]	CVE: GHSA-g644-9gfx-q4q4 vm2 Sandbox Escape vulnerability (CRITICAL) Affected versions: <= 3.9.19 Patched version: No patched versions	yarn.lock	⚠︎
Critical CVE	npm/[email protected]	CVE: GHSA-7jxr-cg7f-gpgv vm2 vulnerable to sandbox escape (CRITICAL) Affected versions: < 3.9.15 Patched version: 3.9.15	yarn.lock	⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]