-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Billing Fixes #1159
Billing Fixes #1159
Conversation
Ensure stripe and jetstream are always in sync, triggered by someone going to the billing plan, we check to ensure that we have alignment of data and make adjustments internally as needed Change chrome extension favicon to match pro icon branding Track click events for billing to see how the features are interacted with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 48 out of 63 changed files in this pull request and generated no comments.
Files not reviewed (15)
- apps/jetstream-web-extension/project.json: Language not supported
- apps/jetstream-web-extension/src/manifest.json: Language not supported
- apps/jetstream-web-extension/src/pages/additional-settings/additional-settings.html: Language not supported
- apps/jetstream-web-extension/src/pages/app/app.html: Language not supported
- apps/jetstream-web-extension/src/pages/popup/popup.html: Language not supported
- apps/api/src/app/controllers/billing.controller.ts: Evaluated as low risk
- libs/features/create-object-and-fields/src/CreateFieldsDeployModal.tsx: Evaluated as low risk
- apps/jetstream/src/app/components/core/AppInitializer.tsx: Evaluated as low risk
- libs/features/create-object-and-fields/src/CreateFieldsImportExport.tsx: Evaluated as low risk
- libs/features/automation-control/src/AutomationControlEditor.tsx: Evaluated as low risk
- libs/features/deploy/src/delete-metadata/DeleteMetadataModal.tsx: Evaluated as low risk
- libs/features/deploy/src/add-to-changeset/AddToChangeset.tsx: Evaluated as low risk
- libs/features/deploy/src/DeployMetadataDeployment.tsx: Evaluated as low risk
- apps/api/src/app/controllers/web-extension.controller.ts: Evaluated as low risk
- apps/api/src/app/db/user.db.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
apps/api/src/app/services/stripe.service.ts:132
- Minor formatting inconsistency. The comment on line 132 should be aligned properly.
recurringInterval: (price.recurring?.interval?.toUpperCase() || null) as StripeUserFacingSubscriptionItem['recurringInterval'],
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 48 out of 63 changed files in this pull request and generated no comments.
Files not reviewed (15)
- apps/jetstream-web-extension/project.json: Language not supported
- apps/jetstream-web-extension/src/manifest.json: Language not supported
- apps/jetstream-web-extension/src/pages/additional-settings/additional-settings.html: Language not supported
- apps/jetstream-web-extension/src/pages/app/app.html: Language not supported
- apps/jetstream-web-extension/src/pages/popup/popup.html: Language not supported
- apps/api/src/app/controllers/web-extension.controller.ts: Evaluated as low risk
- apps/api/src/app/db/user.db.ts: Evaluated as low risk
- libs/features/deploy/src/delete-metadata/DeleteMetadataModal.tsx: Evaluated as low risk
- apps/api/src/app/controllers/billing.controller.ts: Evaluated as low risk
- libs/features/create-object-and-fields/src/CreateFieldsDeployModal.tsx: Evaluated as low risk
- apps/jetstream/src/app/components/core/AppInitializer.tsx: Evaluated as low risk
- libs/features/create-object-and-fields/src/CreateFieldsImportExport.tsx: Evaluated as low risk
- libs/features/automation-control/src/AutomationControlEditor.tsx: Evaluated as low risk
- libs/features/deploy/src/DeployMetadataDeployment.tsx: Evaluated as low risk
- libs/features/deploy/src/add-to-changeset/AddToChangeset.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)
apps/api/src/app/services/stripe.service.ts:199
- The function synchronizeStripeWithJetstreamIfRequired has complex logic and multiple branches. Ensure it is covered by tests to verify all paths.
export async function synchronizeStripeWithJetstreamIfRequired({
Report too large to display inline |
Ensure stripe and jetstream are always in sync, triggered by someone going to the billing plan, we check to ensure that we have alignment of data and make adjustments internally as needed
Change chrome extension favicon to match pro icon branding
Track click events for billing to see how the features are interacted with