Make extract algorithm forward tuple. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfalcou
approved these changes
Jun 2, 2024
jfalcou
reviewed
Jun 2, 2024
include/kumi/algorithm/extract.hpp
Outdated
| , [[maybe_unused]] index_t<I0> i0 | ||
| , [[maybe_unused]] index_t<I1> i1 | ||
| ) noexcept | ||
| { | ||
| return [&]<std::size_t... N>(std::index_sequence<N...>) | ||
| { | ||
| return kumi::tuple<std::tuple_element_t<N + I0, Tuple>...> {get<N + I0>(t)...}; | ||
| return kumi::tuple<element_t<N + I0, Tuple &&>...> {get<N + I0>(KUMI_FWD(t))...}; |
There was a problem hiding this comment.
MSVC sometiems chokes on alias. Try typename element_t::type instead
jehelset
force-pushed
the
jeh/extract
branch
2 times, most recently
from
554ca1a to
02547be
Compare
Use forwarding for `extract`, use `kumi::element_t` instead of `std::tuple_element_t` and add a test.
jehelset
force-pushed
the
jeh/extract
branch
from
02547be to
83516ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use forwarding for
extract, usekumi::element_tinstead ofstd::tuple_element_tand add a test.Didn't constrain the algo, so didn't add test for compilation failure.