-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualified fn module generation #239
Qualified fn module generation #239
Conversation
The branch can be tried out by running:
|
3549167
to
4688e92
Compare
The #237 branch had conflicts so I had to rebase both branches and force push onto your branch. So please pull the changes before you make new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the automated elm-review
rule!
We don't need to create an internal elm-review
package, you could have put the rule directly in review/src/
+review/tests/
without creating a package (that's why there is a review/src/
folder actually).
I'll clean it up in a follow-up PR
elm/
:core
,html
,parser
,random
,json
. If we in the future want to supportelm/svg
orelm-explorations/test
for example, this will take a manual step ofelm-codegen run
on the downloadedelm.json
I've looked through the leftover tuples and none of them were e.g. misspelled fns, so the rule seems to have caught everything.
If you think anything could be improved, like adding doc comments for the declarations and/or module, leave a comment.