Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualified fn module generation #239

Merged
merged 13 commits into from
Oct 4, 2023

Conversation

lue-bird
Copy link
Collaborator

@lue-bird lue-bird commented Oct 4, 2023

  • adds a codegen package fn modules generator
  • adds all package fn modules for elm/: core, html, parser, random, json. If we in the future want to support elm/svg or elm-explorations/test for example, this will take a manual step of elm-codegen run on the downloaded elm.json
  • adds an elm-review rule to replace the manual tuples + imports
  • applies the necessary fixes

I've looked through the leftover tuples and none of them were e.g. misspelled fns, so the rule seems to have caught everything.

If you think anything could be improved, like adding doc comments for the declarations and/or module, leave a comment.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

The branch can be tried out by running:

elm-review --template jfmengels/elm-review-simplify/preview

@jfmengels jfmengels force-pushed the qualified-fn-module-generation branch from 3549167 to 4688e92 Compare October 4, 2023 06:34
@jfmengels jfmengels changed the base branch from main to concatmap October 4, 2023 06:38
@jfmengels jfmengels changed the base branch from concatmap to main October 4, 2023 06:38
@jfmengels
Copy link
Owner

The #237 branch had conflicts so I had to rebase both branches and force push onto your branch. So please pull the changes before you make new commits.

@lue-bird lue-bird marked this pull request as ready for review October 4, 2023 08:55
Copy link
Owner

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the automated elm-review rule!
We don't need to create an internal elm-review package, you could have put the rule directly in review/src/+review/tests/ without creating a package (that's why there is a review/src/ folder actually).
I'll clean it up in a follow-up PR

@jfmengels jfmengels merged commit 34418fa into jfmengels:main Oct 4, 2023
@lue-bird lue-bird deleted the qualified-fn-module-generation branch October 4, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants