Support MemberExpressions in no-mutating-methods allowedObjects

jfmengels · Jan 1, 2021 · e40caaa · e40caaa
1 parent 205861e
commit e40caaa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/rules/no-mutating-methods.js b/rules/no-mutating-methods.js
@@ -45,6 +45,10 @@ const create = function (context) {
         return;
       }
 
+      if (node.callee.object.type === 'MemberExpression' && allowedObjects.indexOf(node.callee.object.property.name) !== -1) {
+        return;
+      }
+
       if (node.callee.object.name === 'Object') {
         if (mutatingObjectMethods.indexOf(node.callee.property.name) !== -1) {
           context.report({

diff --git a/test/no-mutating-methods.js b/test/no-mutating-methods.js
@@ -51,6 +51,12 @@ ruleTester.run('no-mutating-methods', rule, {
         allowedObjects: ['R']
       }]
     },
+    {
+      code: 'this.$route.push(a)',
+      options: [{
+        allowedObjects: ['$route']
+      }]
+    },
     'Object.keys(a)',
     'Object.values(a)'
   ],