[ansible/artifactory] refactored Nginx role (DRY). #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbaassssiiee Thanks for the PR. Its look like a big change, we would like to review this internally and get back to you shortly. |
|
@olwe0002 You raised issue #323, maybe you can review this PR? Especially the Debian/Ubuntu part. |
|
Fix for #323 |
Actually this reduces the amount of code to maintain. |
bbaassssiiee
force-pushed
the
feature/323
branch
from
b6db6e2
to
615ba2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[ansible/artifactory])What this PR does / why we need it:
There were two roles in master that basically did the same thing and duplicated a lot of code:
I rewrote artifactory_nginx so it behaves just like the other two (which were mutually exclusive in use). Also I added a way to install the Nginx module 1.20 (or newer) from the Yum repo's configured on the machine. This is helpful in on-premises deployments where every proxy whitelist item needs permission from security.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Partial fix for #323
Special notes for your reviewer: