-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list all files under specific folder #307
base: dev
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
I have read the CLA Document and I hereby sign the CLA |
8782565
to
15dd576
Compare
recheckcla |
7bbf59a
to
42a5671
Compare
recheckcla |
I have read the CLA Document and I hereby sign the CLA |
recheckcla |
42a5671
to
7bbf59a
Compare
|
||
import java.util.List; | ||
|
||
public interface FileList { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this new interface (and its implementing class)?
I can see that it is used as the returned value for this new API -
FileList list = folder.list(deep, listFolders, timeStamps);
but the returned value of this API can also be -
List<ListItem>= folder.list(deep, listFolders, timeStamps);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i need it for the deserialization because the return data has this structure:
String uri;
Date created;
ListItemImpl[] files;
services/src/main/groovy/org/jfrog/artifactory/client/impl/FolderHandleImpl.groovy
Outdated
Show resolved
Hide resolved
services/src/main/groovy/org/jfrog/artifactory/client/impl/FolderHandleImpl.groovy
Outdated
Show resolved
Hide resolved
services/src/main/groovy/org/jfrog/artifactory/client/impl/FolderHandleImpl.groovy
Outdated
Show resolved
Hide resolved
services/src/main/groovy/org/jfrog/artifactory/client/impl/RepositoryHandleImpl.groovy
Outdated
Show resolved
Hide resolved
b642e42
to
cd13ec2
Compare
cd13ec2
to
f56e539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eyalbe4 Can i merge now?
|
||
import java.util.List; | ||
|
||
public interface FileList { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i need it for the deserialization because the return data has this structure:
String uri;
Date created;
ListItemImpl[] files;
i want to have the info of all files under a specific directory, the folder.getChildren not enough because i dont want to do large recursive calls. There is a rest api call for this:
https://www.jfrog.com/confluence/display/rtf/artifactory+rest+api#ArtifactoryRESTAPI-FileList