Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list all files under specific folder #307

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

I-Iege
Copy link

@I-Iege I-Iege commented Jan 27, 2021

i want to have the info of all files under a specific directory, the folder.getChildren not enough because i dont want to do large recursive calls. There is a rest api call for this:
https://www.jfrog.com/confluence/display/rtf/artifactory+rest+api#ArtifactoryRESTAPI-FileList

@github-actions
Copy link

github-actions bot commented Jan 27, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@I-Iege
Copy link
Author

I-Iege commented Jan 27, 2021

I have read the CLA Document and I hereby sign the CLA

@I-Iege I-Iege changed the title add file list to readme list all files under specific folder Jan 27, 2021
@I-Iege
Copy link
Author

I-Iege commented Jan 29, 2021

recheckcla

@I-Iege I-Iege force-pushed the list_all_files branch 3 times, most recently from 7bbf59a to 42a5671 Compare February 1, 2021 11:56
@I-Iege
Copy link
Author

I-Iege commented Feb 1, 2021

recheckcla

@I-Iege
Copy link
Author

I-Iege commented Feb 1, 2021

I have read the CLA Document and I hereby sign the CLA

@I-Iege
Copy link
Author

I-Iege commented Feb 1, 2021

recheckcla


import java.util.List;

public interface FileList {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this new interface (and its implementing class)?
I can see that it is used as the returned value for this new API -

FileList list = folder.list(deep, listFolders, timeStamps);

but the returned value of this API can also be -

List<ListItem>= folder.list(deep, listFolders, timeStamps);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i need it for the deserialization because the return data has this structure:
String uri;
Date created;
ListItemImpl[] files;

@I-Iege I-Iege force-pushed the list_all_files branch 5 times, most recently from b642e42 to cd13ec2 Compare February 18, 2021 13:53
Copy link
Author

@I-Iege I-Iege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyalbe4 Can i merge now?


import java.util.List;

public interface FileList {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i need it for the deserialization because the return data has this structure:
String uri;
Date created;
ListItemImpl[] files;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants