Skip to content

Commit

Permalink
fixed PR issues
Browse files Browse the repository at this point in the history
  • Loading branch information
eranturgeman committed Aug 2, 2023
1 parent 46734a5 commit 1abd246
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/utils/yarn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func checkGetYarnDependencies(t *testing.T, versionDir string, expectedLocators
assert.Equal(t, "9.0.6", depInfo.Details.Version)
assert.Nil(t, depInfo.Details.Dependencies)
case "loose-envify":
assert.NotNil(t, depInfo.Details.Dependencies) // TODO check according to amount of kids and not nil/no nil
assert.NotNil(t, depInfo.Details.Dependencies)
assert.Equal(t, len(depInfo.Details.Dependencies), 1)
case "js-tokens":
assert.Nil(t, depInfo.Details.Dependencies)
Expand All @@ -161,7 +161,7 @@ func checkGetYarnDependencies(t *testing.T, versionDir string, expectedLocators
for _, dependency := range root.Details.Dependencies {
assert.Contains(t, expectedLocators, dependency.Locator)
}
default: // TODO make another case of root value and default to throw error
default:
assert.NoError(t, errors.New("package "+dependencyName+" should not be inside the dependencies map"))
}
}
Expand Down

0 comments on commit 1abd246

Please sign in to comment.