Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm commands missing standard output #181

Merged
merged 10 commits into from
Aug 20, 2023
Merged

Fix npm commands missing standard output #181

merged 10 commits into from
Aug 20, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Aug 13, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

should fix jfrog/jfrog-cli#2089

Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 changed the title Fix npm commands standart output Fix npm commands missing standard output Aug 13, 2023
@sverdlov93 sverdlov93 added the bug Something isn't working label Aug 13, 2023
@sverdlov93 sverdlov93 requested a review from yahavi August 13, 2023 09:12
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a follow-up with a test to jfrog-cli project, to ensure this functionality does not break in the future.

Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 merged commit 52ff32c into dev Aug 20, 2023
23 of 24 checks passed
@sverdlov93 sverdlov93 deleted the fix-npm-ouput branch August 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants