Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds support for all yarn version by removing the minimun versio… #183

Closed
wants to merge 1 commit into from

Conversation

grinish21
Copy link

…n check.

PR #172 adds supports for yarn V1 but fails to actually enable it when building via the API's

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

…n check.

PR jfrog#172 adds supports for yarn V1 but fails to actually enable it when building via the API's
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@eranturgeman
Copy link
Contributor

eranturgeman commented Aug 15, 2023

Thank you @grinish21 for your contribution for our code!
Supporting in Yarn V1 is on our track, but it will take some time to fully support all the functionalities we have for Yarn V2.
Our recent additions added support in Jfrog CLI command and for creating fixes using Frogbot
The block you requested to remove is there for a reason, since we are not supporting buildInfo with Yarn 1 currently.
We keep adding more and more support for Yarn V1, as long with support to other package managers so stay tuned for further improvements

@grinish21
Copy link
Author

Thank you @grinish21 for your contribution for our code! Supporting in Yarn V1 is on our track, but it will take some time to fully support all the functionalities we have for Yarn V2. Our recent additions added support in Jfrog CLI command and for creating fixes using Frogbot The block you requested to remove is there for a reason, since we are not supporting buildInfo with Yarn 1 currently. We keep adding more and more support for Yarn V1, as long with support to other package managers so stay tuned for further improvements

Thank you @eranturgeman . been waiting for the Yarn V1 support for a while So was excited to see the PR and use the latest version and i realized that check on min version is stopping it. But either ways I will be keeping an eye for yarn V1 support is there an issue or feature we can monitor for completion.

@grinish21
Copy link
Author

since the yarnV1 support is still in progress closing the PR as this is not needed at the moment.

@grinish21 grinish21 closed this Aug 15, 2023
@grinish21 grinish21 mentioned this pull request Aug 15, 2023
@grinish21 grinish21 deleted the fix/yarn-v1-support branch September 14, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants