Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to calculate npm tree only by package-lock.json file #194

Merged
merged 9 commits into from
Oct 3, 2023

Conversation

asafambar
Copy link
Contributor

@asafambar asafambar commented Sep 12, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR introduce more control on the possible ways npm tree is calculated:

  1. create the tree (which is the "ls" command) only by the package-lock file, with no mater if node modules exists.
  2. if package-lock exists, check if the package.json is more updated than the lock, if so, then recalculate th package-lock file.

build/utils/npm.go Outdated Show resolved Hide resolved
build/utils/npm.go Outdated Show resolved Hide resolved
build/utils/npm.go Outdated Show resolved Hide resolved
build/utils/npm.go Outdated Show resolved Hide resolved
build/utils/npm_test.go Outdated Show resolved Hide resolved
build/utils/npm_test.go Outdated Show resolved Hide resolved
build/utils/npm_test.go Outdated Show resolved Hide resolved
@yahavi yahavi added the improvement Automatically generated release notes label Sep 20, 2023
@jfrog jfrog deleted a comment from asafambar Oct 3, 2023
@yahavi yahavi merged commit 3a09931 into jfrog:dev Oct 3, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants