Support running npm install without package.json #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahavi
force-pushed
the
no-package-json
branch
from
a06d73c
to
4747a71
Compare
yahavi
force-pushed
the
no-package-json
branch
from
4747a71
to
57b4655
Compare
This was referenced Oct 18, 2023
eyalbe4
requested changes
Oct 19, 2023
| @@ -73,3 +73,11 @@ func PrintBuildInfoMismatch(t *testing.T, expected, actual []entities.Module) { | |||
| assert.NoError(t, err) | |||
| t.Errorf("build-info don't match. want: \n%v\ngot:\n%s\n", string(excpectedStr), string(actualStr)) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I'm not sure it's the right thing to place this file inside the testdata directory, since this durectory shouldn't include code.
Let's move this file to be under the utils package. We also ready have a utils_test.go file thsi code can be merged into.
There was a problem hiding this comment.
I couldn't put it in the utils package because it makes a cyclic import. I moved this file into a new "tests" package.
yahavi
force-pushed
the
no-package-json
branch
from
8781e81
to
1ab84c6
Compare
yahavi
force-pushed
the
no-package-json
branch
from
1ab84c6
to
9712af4
Compare
yahavi
force-pushed
the
no-package-json
branch
from
9712af4
to
bbe62f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent PRs:
Allow running npm install (
jf npm install <package-name>) withoutpackage.jsonfile.