Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven/Gradle Artifacts build.timestamp property #209

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 31, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

At build-info-extractor in ArtifactoryClientConfiguration (at the addDefaultPublisherAttributes method) we sets the timestamp to the buildestarted timestamp if it does not exist:
image

For Maven and Gradle, when creating properties, we didn't pass a timestamp, so BuildStarted was used.

If a general timestamp was already defined, it was ignored. This PR addresses this issue and passes the correct values.

This issue caused the "undefined/No path found (externally resolved or deleted/overwritten)" error in the Repo path column for Maven and Gradle artifacts with multiple modules:
image

@attiasas attiasas added the bug Something isn't working label Oct 31, 2023
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before mergint this PR, let's create a PR for an integration test in the jfrog-cli project, or emajnce an existing interation test, to verify this functionality.

utils/dependenciesutils.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.timestamp artifacts property should be equal for all artifacts in Build Modules
2 participants