Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible race condition when running commands #216

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Possible race condition when running commands #216

merged 2 commits into from
Nov 30, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 29, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on jfrog/gofrog#41

@yahavi yahavi added the ignore for release Automatically generated release notes label Nov 29, 2023
@yahavi yahavi changed the title Race condition in RunCmdWithOutputParser Update gofrog to latest dev Nov 29, 2023
@yahavi yahavi changed the title Update gofrog to latest dev Race condition in RunCmdWithOutputParser Nov 29, 2023
@yahavi yahavi added bug Something isn't working and removed ignore for release Automatically generated release notes labels Nov 29, 2023
@yahavi yahavi self-assigned this Nov 29, 2023
@yahavi yahavi requested a review from attiasas November 29, 2023 12:35
@yahavi yahavi marked this pull request as ready for review November 29, 2023 12:36
This was referenced Nov 29, 2023
Merged
Merged
attiasas
attiasas approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahavi yahavi changed the title Race condition in RunCmdWithOutputParser Possible race condition when running commands Nov 30, 2023
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@yahavi yahavi merged commit 25c7986 into jfrog:dev Nov 30, 2023
14 checks passed
@yahavi yahavi deleted the run-tests branch November 30, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @attiasas