Fix Nupkg/Nuspec UTF-16 encoding and support uppercase dependencies #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93
changed the title
sverdlov93
changed the title
Signed-off-by: Michael Sverdlov <[email protected]>
|
What's going on with this PR, as I haven't seen any movement on this for about 2 weeks? I'm looking for this fix, as I'm gearing up to go to production soon and would like to know if I'll be able to use the JFrog Restore task in my build pipelines. |
Signed-off-by: Michael Sverdlov <[email protected]>
yahavi
requested changes
Feb 16, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
|
Awesome, glad to see this has been completed. Has this been formally released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing Nuget
nuspecfiles sometimes they can be utf16 files so we need to encode them because Golang's Unmashall doesn't support utf-16 encoding.The previous fix wasn't enough for all cases.
Added a real utf16 example to test this.
Also, fixed an issue where Nuget dependencies with uppercase letters couldn't be resolved.
should fix jfrog/jfrog-azure-devops-extension#475