Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify GetFileChecksums to receive the algorithms #232

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Modify GetFileChecksums to receive the algorithms #232

merged 6 commits into from
Feb 22, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Feb 18, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Required for jfrog/jfrog-client-go#900

Modify the GetFileChecksums function so that it can take in algorithms, thereby enabling the computation of different checksums for a specified local path.

@yahavi yahavi added the ignore for release Automatically generated release notes label Feb 18, 2024
@yahavi yahavi requested a review from eyalbe4 February 18, 2024 07:13
@yahavi yahavi self-assigned this Feb 18, 2024
@yahavi yahavi mentioned this pull request Feb 18, 2024
Merged
4 tasks
@yahavi yahavi requested a review from RobiNino February 21, 2024 12:22
@yahavi yahavi requested a review from Or-Geva February 22, 2024 07:55
@Or-Geva Or-Geva changed the title Make GetFileChecksums receive the algorithms Modify GetFileChecksums to receive the algorithms Feb 22, 2024
Or-Geva
Or-Geva requested changes Feb 22, 2024
View reviewed changes
build/golang.go Outdated Show resolved Hide resolved
build/utils/npm.go Outdated Show resolved Hide resolved
utils/checksum_test.go Outdated Show resolved Hide resolved
utils/checksum_test.go Outdated Show resolved Hide resolved
@yahavi yahavi merged commit bd9687a into jfrog:dev Feb 22, 2024
13 of 14 checks passed
@yahavi yahavi deleted the get-file-checksums branch February 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Or-Geva Or-Geva Or-Geva requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@RobiNino RobiNino Awaiting requested review from RobiNino

Assignees

@yahavi yahavi

Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @Or-Geva