fix: same vcs info appened twice when running jf rt build-add-git command twice #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrnot
commented
Apr 19, 2024
•
gerrnot
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
|
Hey @gerrnot We've just update to go 1.22.3, |
gerrnot
force-pushed
the
feat/bag-regex-multiline
branch
from
08bf567
to
ba194e9
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
added 18 commits
June 3, 2024 18:39
…mand twice It turns out to be practical if you can perform issue collection multiple times using different configurations (different regexes). However, in this case (and in any case) you do not want to see the vcs information duplicated. This is fixed hereby.
gerrnot
force-pushed
the
feat/bag-regex-multiline
branch
from
3d191cf
to
f4cdc63
Compare
|
@EyalDelarea Thanks, yes, the build was green after that. I rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.