Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize "403 forbidden" error from mvn command output, and clasiffy it as "forbidden" error type #267

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

asafambar
Copy link
Contributor

@asafambar asafambar commented Aug 7, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Description:
After running "mvn " and encountering an error, we examine the output from stderr. If the output includes a "403 Forbidden", we wrap the error with a specific error type for "Forbidden 403." This error type will be recognized later by post actions, such as curation.

@asafambar asafambar changed the title Add Mvn install stderr to error Recognize "403 forbidden" error from mvn command output, and clasiffy it as "forbidden" error type Aug 13, 2024
utils/error.go Outdated Show resolved Hide resolved
utils/error.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 merged commit bb14890 into jfrog:dev Aug 20, 2024
15 of 16 checks passed
@eyalbe4 eyalbe4 added the improvement Automatically generated release notes label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants